Skip to content

Commit

Permalink
fixup! fixup! build: migrate from yarn v1 to npm
Browse files Browse the repository at this point in the history
  • Loading branch information
caugner committed May 20, 2022
1 parent 0e5bb60 commit c5aef38
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 12 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/dev-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -148,9 +148,9 @@ jobs:
# Spread the work across 2 processes. Why 2? Because that's what you
# get in the default GitHub hosting Linux runners.
# See https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources
npm run build --locale en-us --locale ja --locale fr &
npm run build -- --locale en-us --locale ja --locale fr &
build1=$!
npm run build --not-locale en-us --not-locale ja --not-locale fr &
npm run build -- --not-locale en-us --not-locale ja --not-locale fr &
build2=$!
# You must explicitly specify the job you're waiting-on to ensure
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/prod-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,9 @@ jobs:
# Spread the work across 2 processes. Why 2? Because that's
# what you get in the default GitHub-hosted Linux runners.
# See https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources
npm run build --locale en-us --locale ja --locale fr &
npm run build -- --locale en-us --locale ja --locale fr &
build1=$!
npm run build --not-locale en-us --not-locale ja --not-locale fr &
npm run build -- --not-locale en-us --not-locale ja --not-locale fr &
build2=$!
# You must explicitly specify the job you're waiting-on to ensure
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/stage-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,9 @@ jobs:
# Spread the work across 2 processes. Why 2? Because that's what you
# get in the default GitHub hosting Linux runners.
# See https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources
npm run build --locale en-us --locale ja --locale fr &
npm run build -- --locale en-us --locale ja --locale fr &
build1=$!
npm run build --not-locale en-us --not-locale ja --not-locale fr &
npm run build -- --not-locale en-us --not-locale ja --not-locale fr &
build2=$!
# You must explicitly specify the job you're waiting-on to ensure
Expand Down
8 changes: 4 additions & 4 deletions testing/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ The last command is just an alias for `jest` so you can run, for example:

```sh
# See jest help
npm run test:testing --help
npm run test:testing -- --help
# Interactive re-run every time a file is saved and exit on the first error
npm run test:testing --watch --bail
npm run test:testing -- --watch --bail
# Alias for searching by test file name. I.e. only run `index.test.js`
npm run test:testing index
```
Expand Down Expand Up @@ -77,9 +77,9 @@ some quick tips to get you started.

```sh
# Just run the test by a test description string
npm run test:headless -g 'show your settings page'
npm run test:headless -- -g 'show your settings page'
# Make it NOT headless by making a browser pop up for each test
npm run test:headless --headed
npm run test:headless -- --headed
# Exclusively run the tests in headless.sitesearch.spec.js only
playwright test headless.sitesearch
```
Expand Down
2 changes: 1 addition & 1 deletion testing/scripts/functional-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ export ENV_FILE=testing/.env
npm run build:prepare
npm run build

npm run test:testing $@
npm run test:testing -- $@
2 changes: 1 addition & 1 deletion tool/cli.js
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,7 @@ program
)
);
logger.info(
`Reset ${outfile} by running: npm run tool popularities --refresh`
`Reset ${outfile} by running: npm run tool popularities -- --refresh`
);
return;
}
Expand Down

0 comments on commit c5aef38

Please sign in to comment.