Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change a picture which is not suitable #746

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hanyujie2002
Copy link

@hanyujie2002 hanyujie2002 commented Jul 1, 2024

Accroding to mdn/translated-content#19529, I swap the picture of a eye to make it more comforting

Image cropped from https://en.wikipedia.org/wiki/Culture_of_the_United_States#/media/File:Aldrin_Apollo_11_original.jpg which is in public domain

@hanyujie2002 hanyujie2002 requested a review from a team as a code owner July 1, 2024 10:56
@hanyujie2002 hanyujie2002 requested review from pepelsbey and removed request for a team July 1, 2024 10:56
@hanyujie2002 hanyujie2002 changed the title Add files via upload change a picture which is not comfortable Jul 1, 2024
@hanyujie2002 hanyujie2002 changed the title change a picture which is not comfortable change a picture which is not suitable Jul 1, 2024
@yin1999
Copy link
Member

yin1999 commented Jul 2, 2024

We also need to update the screenshot in mdn/content

@hanyujie2002
Copy link
Author

We also need to update the screenshot in mdn/content

This is upstream, maybe it's better not to update that screenshot until this pr being merged.

@hanyujie2002
Copy link
Author

Would you please merge it? :) @yin1999

@yin1999
Copy link
Member

yin1999 commented Jul 15, 2024

I do not have the permission. In addition, as I said above, if you want to change the images, please also create a corresponding PR in mdn/content to modify the screenshot.

@fuchunhui
Copy link

Here are the adjustments to the images, which need to adjust the examples and default images in mdn/content.

Hh, whose eyes will this be? @chrisdavidmills

@pepelsbey
Copy link
Member

I believe the current pictures are just a bunch of kid’s photos. The one with the eye is a selfie of some sort 😁 But I agree, in general, that the gallery example deserves more neutral pictures. How about we replace them all to keep the same style? Otherwise, the astronaut picture sticks out a bit.

@chrisdavidmills
Copy link
Contributor

I believe the current pictures are just a bunch of kid’s photos. The one with the eye is a selfie of some sort 😁 But I agree, in general, that the gallery example deserves more neutral pictures. How about we replace them all to keep the same style? Otherwise, the astronaut picture sticks out a bit.

That's my son's eye, from when he was about 6. He's now 22, so I am chilled about replacing it ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants