-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change a picture which is not suitable #746
base: main
Are you sure you want to change the base?
Conversation
We also need to update the screenshot in mdn/content |
This is upstream, maybe it's better not to update that screenshot until this pr being merged. |
Would you please merge it? :) @yin1999 |
I do not have the permission. In addition, as I said above, if you want to change the images, please also create a corresponding PR in mdn/content to modify the screenshot. |
Here are the adjustments to the images, which need to adjust the examples and default images in mdn/content. Hh, whose eyes will this be? @chrisdavidmills |
I believe the current pictures are just a bunch of kid’s photos. The one with the eye is a selfie of some sort 😁 But I agree, in general, that the gallery example deserves more neutral pictures. How about we replace them all to keep the same style? Otherwise, the astronaut picture sticks out a bit. |
That's my son's eye, from when he was about 6. He's now 22, so I am chilled about replacing it ;-) |
Accroding to mdn/translated-content#19529, I swap the picture of a eye to make it more comforting
Image cropped from https://en.wikipedia.org/wiki/Culture_of_the_United_States#/media/File:Aldrin_Apollo_11_original.jpg which is in public domain