Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set <p> element's color to initial (from CanvasText) #2802

Merged
merged 9 commits into from
Jul 11, 2024

Conversation

manav-sharma69
Copy link
Contributor

Description

Set the <p> element's color to initial would replace the inherited CanvasText color and set to its initial color (black - I guess), making it visible.

Motivation

Make paragraph text visible.

Additional details

In case someone considers the changes "not the best practice", initial property is used to reset the color of for an element

Related issues and pull requests

Fixes #2798

@manav-sharma69 manav-sharma69 requested a review from a team as a code owner July 1, 2024 13:07
@manav-sharma69 manav-sharma69 requested review from estelle and removed request for a team July 1, 2024 13:07
Copy link

github-actions bot commented Jul 1, 2024

It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@estelle estelle merged commit a0837d8 into mdn:main Jul 11, 2024
5 checks passed
Copy link

Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution.

@manav-sharma69 manav-sharma69 deleted the patch-1 branch July 11, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change color of <p> element in <dialog> element to make it visible.
2 participants