-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(prettier): Ignore implicit closing bracket in rtc element #2592
chore(prettier): Ignore implicit closing bracket in rtc element #2592
Conversation
Is the point of the test to demonstrate that there's an implicit closing bracket...? (Side note, I can't find where this example is referenced in content...) |
It's used here: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/rtc
No, Prettier throws an error if there's a closing
Note this is also valid and passes <rtc xml:lang="en" style="ruby-position: over;"/>
<rp>(</rp><rt>Malaysia</rt><rp>)</rp> If we remove the Prettier ignore and let the formatter do it's thing it looks like this: <ruby xml:lang="zh-Hant" style="ruby-position: under">
<rbc>
<rb>馬</rb><rp>(</rp><rt>mǎ</rt><rp>)</rp> <rb>來</rb><rp>(</rp><rt>lái</rt><rp>)</rp> <rb>西</rb><rp>(</rp
><rt>xī</rt><rp>)</rp> <rb>亞</rb><rp>(</rp><rt>yà</rt><rp>)</rp>
</rbc>
<rtc xml:lang="en" style="ruby-position: over" />
<rp>(</rp><rt>Malaysia</rt><rp>)</rp>
</ruby> Note that this element is considered deprecated so I don't think it's necessary to worry over adding special handling here for tests to pass. |
@bsmth Maybe add |
* Run all linting actions in CI workflow * Run Prettier * chore(prettier): Ignore implicit closing bracket in rtc element (#2592) * chore: Ignore implicit closing bracket in rtc element * chore: add rtc element example to .prettierignore * style(prettier): ignore CHANGELOG * chore: revert CHANGELOG.md * style: run `prettier -w .` --------- Co-authored-by: Brian Thomas Smith <[email protected]> Co-authored-by: Claas Augner <[email protected]>
Slightly ugly workaround to get tests to pass in #2576
This is the only case of a magic comment necessary, I think we can allow one exception for this.