Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS import at-rule #2299

Closed
wants to merge 2 commits into from
Closed

Add CSS import at-rule #2299

wants to merge 2 commits into from

Conversation

NiedziolkaMichal
Copy link
Member

This is interactive example for @import.

image

@bsmth
Copy link
Member

bsmth commented Dec 6, 2022

Thanks @NiedziolkaMichal. Usually we're expecting the reader to be able to click through a few options and see the result, but I'm not sure we're adding anything to the article with this. Do you think @import deserves an interactive example? I would lean towards leaving it out.

@NiedziolkaMichal
Copy link
Member Author

I think you are right. What if I would add media query or supports to the example, so more functionalities are displayed? Do you think it would make interactive example useful to the user?

@bsmth
Copy link
Member

bsmth commented Dec 6, 2022

What if I would add media query or supports

We could do, if we're doing something with conditionals, supports or layers it might be interesting. Is there anything that's in the examples section that would be better demonstrated by user interaction? I'm not sure 🤔

@bsmth bsmth changed the title import at-rule Add CSS import at-rule Dec 7, 2022
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Jan 19, 2023
@Josh-Cena Josh-Cena added the Content:CSS issues related to CSS examples. label Jul 31, 2023
@github-actions github-actions bot removed the idle Issues and pull requests with no activity for three months. label Aug 1, 2023
@bsmth
Copy link
Member

bsmth commented Aug 18, 2023

There are some good options we can include from the examples like:

@import url("whatever.css") supports(font-tech(color-COLRv1));

@import "theme.css" layer(utilities);

@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Sep 18, 2023
@bsmth
Copy link
Member

bsmth commented Oct 30, 2023

Usually we're expecting the reader to be able to click through a few options and see the result, but I'm not sure we're adding anything to the article with this. Do you think @import deserves an interactive example? I would lean towards leaving it out.

I'm going to close this one for now with this in mind unless there's something I'm missing that's really useful with interactivity in mind. Thank you :)

@bsmth bsmth closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS issues related to CSS examples. idle Issues and pull requests with no activity for three months.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants