Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(editor): confirm before reset #2052

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Nov 14, 2024

Fixes #1739.

@caugner caugner requested a review from a team as a code owner November 14, 2024 11:59
@caugner caugner force-pushed the 1739-add-reset-confirmation branch from 2b4b3ea to be49915 Compare November 14, 2024 12:19
@caugner caugner changed the title enhance(editor): confirm before reset/reload enhance(editor): confirm before reset Nov 14, 2024
@caugner caugner force-pushed the 1739-add-reset-confirmation branch from be49915 to d937916 Compare November 14, 2024 12:21
@bsmth bsmth self-requested a review November 14, 2024 12:54
editor/js/editable-css.ts Outdated Show resolved Hide resolved
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one minor comment about copy, but it's working well! 👍🏻

Thank you!

Co-authored-by: Brian Thomas Smith <[email protected]>
@caugner caugner requested a review from bsmth November 14, 2024 22:48
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@caugner caugner merged commit 73037f7 into main Dec 20, 2024
7 checks passed
@caugner caugner deleted the 1739-add-reset-confirmation branch December 20, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a confirmation dialog when pressing "Reset" on the "Try it" live code examples
2 participants