fix(clippy): reimplement copy logic for CSS editor #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
queengooborg
added
the
on hold
caugner
changed the title
caugner
changed the title
caugner
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
LGTM, tested locally by running npm i && npm start and opening http://localhost:4444/pages/css/animation.html
caugner
changed the title
|
Thank you @NiedziolkaMichal for your great work! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes "Copy" button in the CSS editor, which is supposed to copy the content of the code mirror editor and display the message "Copied!".
I have dropped the
Clipboarddependency because code is actually simpler without it.Fixes #1150
It would be better to merge #1171 before this PR. Here I am adding some temporary walkaround to errors because by importing .ts files from .js files and vice-versa, while #1171 converts all .js to .ts.