Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moodle-mod_customcert_patch_rh #637

Open
wants to merge 10 commits into
base: MOODLE_404_STABLE
Choose a base branch
from
+9 −3
Open

Moodle-mod_customcert_patch_rh #637

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1745931
Update template.php
ricardoh34 Sep 3, 2021
ef0d658
Update template.php
ricardoh34 Sep 17, 2021
0f16d6a
Add student name to PDF certificate file
ricardoh34 Sep 30, 2021
81341f6
Corrected mistakes from @mdjnelson comments
ricardoh34 Oct 22, 2021
ebf4a1c
Added new space in line 266
ricardoh34 Nov 28, 2021
d1ac2cb
Erase tabs
ricardoh34 Aug 21, 2024
8abcab0
Update template.php
ricardoh34 Sep 3, 2021
828689d
Update template.php
ricardoh34 Aug 26, 2024
3d6ca8c
Merge branch 'moodle-mod_customcert_patch_rh' of https://github.com/r…
ricardoh34 Aug 26, 2024
e80e276
Merge branch 'MOODLE_404_STABLE' into moodle-mod_customcert_patch_rh
ricardoh34 Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions classes/template.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ public function delete_element($elementid) {
public function generate_pdf(bool $preview = false, ?int $userid = null, bool $return = false) {
global $CFG, $DB, $USER;

if (empty($userid)) {
if (empty($userid)) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this change made?

$user = $USER;
} else {
$user = \core_user::get_user($userid);
Expand Down Expand Up @@ -330,8 +330,14 @@ public function generate_pdf(bool $preview = false, ?int $userid = null, bool $r
if (empty($filename)) {
$filename = get_string('certificate', 'customcert');
}

$filename = clean_filename($filename . '.pdf');

$sql = "SELECT course,fullname
FROM {customcert} c, {course} cr
WHERE c.id = :templateid
AND c.course = cr.id";
$course = $DB->get_record_sql($sql, array('templateid' => $this->id));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SQL parameters have to be aligned. See https://moodledev.io/general/development/policies/codingstyle/sql#indentation.

$filename = clean_filename($filename .'_'. fullname($USER) .'_'. $course->fullname . '.pdf');

// Loop through the pages and display their content.
foreach ($pages as $page) {
// Add the page to the PDF.
Expand Down