Extraction of private digital signature parameters to external configuration #462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To preserve the privacy of critical parts of the digital signature (private key and password), this patch allows to configure them externally in the site configuration (i.e.,
config.php
and the like).Two new configuration parameters are introduced,
customcert_signature_private_keys
andcustomcert_signature_passwords
. Both are associative arrays with a similar structure. Their values are the value/location of the private keys and the passwords, respectively. Their keys are thecontext_id
of the digital signature element instances. If no such key is found, a wildcard key'*'
is looked for (useful, for instance, when the whole site will share the same signing certificate configuration). If none of them is defined, falls back to the previous behaviour (i.e., configured by editing the element in the site administration interface).