Support right to left certificates #371
Conversation
|
Excuse my ignorance but can't people using RTL languages just move the words to the right instead of the left? |
|
No. At the moment what they see on the drag and drop designer page is not what the generated PDF will look like. They put an element on the left of the designer page and to their surprise, they see that element on the right on the pdf.
|
|
Also, direction and alignment are 2 separate things
|
|
Hi Mark, |
|
Definitely has not been forgotten. It is in the list of issues I am going to do before releasing a new version. I am in the middle of moving countries and right now am working on other things to make much needed money rather than my open source projects. This should settle down once I am back in Australia. |
|
So, I have worked with RTL languages before. In this case I still don't see why a user can not type out the string in a RTL language and then position it accordingly. I would download the Hebrew language pack and check how this works when filling in an input field but the internet is so slow at the hotel I am being quarantined at that it fails to download. What happens on input fields, do the new characters get added to the start of the input field when you are typing? Can you please provide an example for my ignorant mind on what this setting does. Pretend you are writing testing instructions on Jira :) Also, can you address my PR comments, an ignorant person like myself will have no idea what direction means when editing the certificate. Thanks Shamim! |
|
Hi Mark, Apart from the above, here is just a case that the current code fails. Fail case 1
|
| @@ -58,6 +58,10 @@ | |||
| $string['deletepageconfirm'] = 'Are you sure you want to delete this certificate page?'; | |||
| $string['deletetemplateconfirm'] = 'Are you sure you want to delete this certificate template?'; | |||
| $string['description'] = 'Description'; | |||
| $string['direction'] = 'Direction'; | |||
| $string['direction_help'] = 'This is the direction of the certificate PDF.'; | |||
There was a problem hiding this comment.
This needs to be more descriptive. To people who are not familiar with RTL language, or vice versa this will be very confusing.
| @@ -24,7 +24,7 @@ | |||
|
|
|||
| defined('MOODLE_INTERNAL') || die('Direct access to this script is forbidden.'); | |||
|
|
|||
| $plugin->version = 2019111804; // The current module version (Date: YYYYMMDDXX). | |||
| $plugin->version = 2020082000; // The current module version (Date: YYYYMMDDXX). | |||
There was a problem hiding this comment.
Only bump by 1 on the 3.8 branch please.
mdjnelson
changed the title
No description provided.