Only get teachers when emailing certificates if required (#531)

mdjnelson · Oct 12, 2024 · b5a249b · b5a249b
1 parent d8f2aa9
commit b5a249b
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/classes/task/email_certificate_task.php b/classes/task/email_certificate_task.php
@@ -73,9 +73,6 @@ public function execute() {
         // Get the person we are going to send this email on behalf of.
         $userfrom = \core_user::get_noreply_user();
 
-        // Store teachers for later.
-        $teachers = get_enrolled_users($context, 'moodle/course:update');
-
         $courseshortname = format_string($customcert->courseshortname, true, ['context' => $context]);
         $coursefullname = format_string($customcert->coursefullname, true, ['context' => $context]);
         $certificatename = format_string($customcert->name, true, ['context' => $context]);
@@ -140,6 +137,8 @@ public function execute() {
         }
 
         if ($customcert->emailteachers) {
+            $teachers = get_enrolled_users($context, 'moodle/course:update');
+
             $renderable = new \mod_customcert\output\email_certificate(false, $userfullname, $courseshortname,
                 $coursefullname, $certificatename, $context->instanceid);