Skip to content

Commit

Permalink
Merge pull request #69 from miniBill/main
Browse files Browse the repository at this point in the history
Run elm-review, simplify code
  • Loading branch information
mdgriffith authored Aug 26, 2023
2 parents 080656b + 940a331 commit efe66b3
Show file tree
Hide file tree
Showing 38 changed files with 1,083 additions and 1,103 deletions.
47 changes: 23 additions & 24 deletions review/src/ReviewConfig.elm
Original file line number Diff line number Diff line change
Expand Up @@ -39,30 +39,29 @@ config : List Rule
config =
[ NoMissingTypeExpose.rule
, NoUnused.Dependencies.rule

-- , Docs.NoMissing.rule
-- { document = onlyExposed
-- , from = exposedModules
-- }
--, Docs.ReviewLinksAndSections.rule
--, Docs.ReviewAtDocs.rule
--, Docs.UpToDateReadmeLinks.rule
--, NoDebug.Log.rule
--, NoDebug.TodoOrToString.rule
-- |> Rule.ignoreErrorsForDirectories [ "tests/" ]
--, NoExposingEverything.rule
--, NoImportingEverything.rule []
--, NoMissingTypeAnnotation.rule
--, NoMissingTypeAnnotationInLetIn.rule
--, NoSimpleLetBody.rule
--, NoPrematureLetComputation.rule
--, NoUnused.CustomTypeConstructors.rule []
--, NoUnused.CustomTypeConstructorArgs.rule
--, NoUnused.Exports.rule
--, NoUnused.Parameters.rule
--, NoUnused.Patterns.rule
--, NoUnused.Variables.rule
--, Simplify.rule Simplify.defaults
, Docs.NoMissing.rule
{ document = onlyExposed
, from = exposedModules
}
, Docs.ReviewLinksAndSections.rule
, Docs.ReviewAtDocs.rule
, Docs.UpToDateReadmeLinks.rule
, NoDebug.Log.rule
, NoDebug.TodoOrToString.rule
|> Rule.ignoreErrorsForDirectories [ "tests/" ]
, NoExposingEverything.rule
, NoImportingEverything.rule []
, NoMissingTypeAnnotation.rule
, NoMissingTypeAnnotationInLetIn.rule
, NoSimpleLetBody.rule
, NoPrematureLetComputation.rule
, NoUnused.CustomTypeConstructors.rule []
, NoUnused.CustomTypeConstructorArgs.rule
, NoUnused.Exports.rule
, NoUnused.Parameters.rule
, NoUnused.Patterns.rule
, NoUnused.Variables.rule
, Simplify.rule Simplify.defaults
]
|> List.map
(Rule.ignoreErrorsForDirectories
Expand Down
14 changes: 14 additions & 0 deletions review/suppressed/Docs.NoMissing.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"version": 1,
"automatically created by": "elm-review suppress",
"learn more": "elm-review suppress --help",
"suppressions": [
{ "count": 32, "filePath": "src/Elm/Case/Branch.elm" },
{ "count": 29, "filePath": "src/Elm.elm" },
{ "count": 22, "filePath": "src/Elm/Annotation.elm" },
{ "count": 13, "filePath": "src/Elm/Case.elm" },
{ "count": 9, "filePath": "src/Elm/Let.elm" },
{ "count": 8, "filePath": "src/Elm/Declare.elm" },
{ "count": 6, "filePath": "src/Elm/ToString.elm" }
]
}
8 changes: 8 additions & 0 deletions review/suppressed/Docs.ReviewAtDocs.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"version": 1,
"automatically created by": "elm-review suppress",
"learn more": "elm-review suppress --help",
"suppressions": [
{ "count": 2, "filePath": "src/Elm.elm" }
]
}
8 changes: 8 additions & 0 deletions review/suppressed/Docs.ReviewLinksAndSections.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"version": 1,
"automatically created by": "elm-review suppress",
"learn more": "elm-review suppress --help",
"suppressions": [
{ "count": 1, "filePath": "src/Elm.elm" }
]
}
8 changes: 8 additions & 0 deletions review/suppressed/Docs.UpToDateReadmeLinks.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"version": 1,
"automatically created by": "elm-review suppress",
"learn more": "elm-review suppress --help",
"suppressions": [
{ "count": 2, "filePath": "README.md" }
]
}
9 changes: 9 additions & 0 deletions review/suppressed/NoUnused.CustomTypeConstructorArgs.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"version": 1,
"automatically created by": "elm-review suppress",
"learn more": "elm-review suppress --help",
"suppressions": [
{ "count": 1, "filePath": "src/Elm/Op.elm" },
{ "count": 1, "filePath": "src/Internal/Compiler.elm" }
]
}
9 changes: 9 additions & 0 deletions review/suppressed/NoUnused.CustomTypeConstructors.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"version": 1,
"automatically created by": "elm-review suppress",
"learn more": "elm-review suppress --help",
"suppressions": [
{ "count": 4, "filePath": "src/Internal/Compiler.elm" },
{ "count": 1, "filePath": "src/Internal/Comments.elm" }
]
}
9 changes: 9 additions & 0 deletions review/suppressed/NoUnused.Exports.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"version": 1,
"automatically created by": "elm-review suppress",
"learn more": "elm-review suppress --help",
"suppressions": [
{ "count": 1, "filePath": "src/Error/Format.elm" },
{ "count": 1, "filePath": "src/Internal/Debug.elm" }
]
}
8 changes: 8 additions & 0 deletions review/suppressed/NoUnused.Parameters.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"version": 1,
"automatically created by": "elm-review suppress",
"learn more": "elm-review suppress --help",
"suppressions": [
{ "count": 1, "filePath": "src/Internal/Compiler.elm" }
]
}
17 changes: 17 additions & 0 deletions review/suppressed/NoUnused.Variables.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"version": 1,
"automatically created by": "elm-review suppress",
"learn more": "elm-review suppress --help",
"suppressions": [
{ "count": 9, "filePath": "src/Internal/Compiler.elm" },
{ "count": 5, "filePath": "src/Elm.elm" },
{ "count": 5, "filePath": "src/Internal/Write.elm" },
{ "count": 4, "filePath": "src/Internal/Debug.elm" },
{ "count": 2, "filePath": "src/Elm/Op.elm" },
{ "count": 2, "filePath": "src/Internal/Comments.elm" },
{ "count": 2, "filePath": "tests/Pattern.elm" },
{ "count": 1, "filePath": "src/Internal/Index.elm" },
{ "count": 1, "filePath": "tests/Elm/Expect.elm" },
{ "count": 1, "filePath": "tests/PackageHelpers.elm" }
]
}
8 changes: 8 additions & 0 deletions review/suppressed/Simplify.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"version": 1,
"automatically created by": "elm-review suppress",
"learn more": "elm-review suppress --help",
"suppressions": [
{ "count": 2, "filePath": "src/Internal/Compiler.elm" }
]
}
Loading

0 comments on commit efe66b3

Please sign in to comment.