allow m2e to recognize xtext-gen folders as source folders as specifi… #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed by build-helper-maven-plugin for mdeo xtext plugin; ignore fmt-maven-plugin in m2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ed by build-helper-maven-plugin for mdeo xtext plugin; ignore fmt-maven-plugin in m2e
Ignoring fmt-maven-plugin should be no problem. Worst case, the code is not formatted correctly and the next command line build or manual execution of the plugin will fix it. In my opinion, better than letting Eclipse people find out what's going on by themselves.
For the MDEO xtext plugin I removed the part of the lifecycle mapping which ignored the add-source, add-test-source goals of build-helper-maven-plugin. I am not sure why those ignores were added. At least in current versions of m2e there is a dedicated connector for the build-helper-plugin which should be installed. Otherwise, the generated xtext-gen folders are not added as source folders in Eclipse which causes a myriad of errors after import.
I will send a proposal for the Developers Instructions of github.io taking those changes into account.