Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle config changes on docker updates #137

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.13.10-alpine AS builder
FROM golang:1.15.6-alpine AS builder

RUN apk --no-cache add gcc musl-dev

Expand All @@ -7,11 +7,9 @@ COPY . ${GOPATH}/src/github.com/mcuadros/ofelia

RUN go build -o /go/bin/ofelia .

FROM alpine:3.11
FROM alpine:3.12

# this label is required to identify container with ofelia running
LABEL ofelia.service=true
rdelcorro marked this conversation as resolved.
Show resolved Hide resolved
LABEL ofelia.enabled=true

RUN apk --no-cache add ca-certificates tzdata

Expand Down
44 changes: 37 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,6 @@ In order to use this type of configurations, ofelia need access to docker socket
```sh
docker run -it --rm \
-v /var/run/docker.sock:/var/run/docker.sock:ro \
--label ofelia.job-local.my-test-job.schedule="@every 5s" \
--label ofelia.job-local.my-test-job.command="date" \
mcuadros/ofelia:latest daemon --docker
```

Expand All @@ -86,9 +84,8 @@ docker run -it --rm \
nginx
```

Now if we start `ofelia` container with the command provided above, it will pickup 2 jobs:
Now if we start `ofelia` container with the command provided above, it will execute the task:

- Local - `date`
- Exec - `uname -a`

Or with docker-compose:
Expand All @@ -103,9 +100,6 @@ services:
command: daemon --docker
volumes:
- /var/run/docker.sock:/var/run/docker.sock:ro
labels:
ofelia.job-local.my-test-job.schedule: "@every 5s"
ofelia.job-local.my-test-job.command: "date"

nginx:
image: nginx
Expand All @@ -115,6 +109,42 @@ services:
ofelia.job-exec.datecron.command: "uname -a"
```
#### Dynamic docker configuration
You can start ofelia in its own container or on the host itself, and it will magically pick up any container that starts, stops or is modified on the fly.
In order to achieve this, you simply have to use docker containers with the labels described above and let ofelia take care of the rest.
#### Hybrid configuration (INI files + Docker)
You can specify part of the configuration on the INI files, such as globals for the middlewares or even declare tasks in there but also merge them with docker.
The docker labels will be parsed, added and removed on the fly but also, the file config can be used.
**Use the INI file to:**
- Configure the slack or other middleware integration
- Configure any global setting
- Create a job-run so it executes on a new container each time
```ini
[global]
slack-webhook = https://myhook.com/auth

[job-run "job-executed-on-new-container"]
schedule = @hourly
image = ubuntu:latest
command = touch /tmp/example
```

**Use docker to:**

```sh
docker run -it --rm \
--label ofelia.enabled=true \
--label ofelia.job-exec.test-exec-job.schedule="@every 5s" \
--label ofelia.job-exec.test-exec-job.command="uname -a" \
nginx
```

### Logging
**Ofelia** comes with three different logging drivers that can be configured in the `[global]` section:
- `mail` to send mails
Expand Down
Loading