Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix argument -x for devel #79

Merged
merged 1 commit into from
Jul 18, 2019
Merged

fix argument -x for devel #79

merged 1 commit into from
Jul 18, 2019

Conversation

slm0n87
Copy link
Contributor

@slm0n87 slm0n87 commented Jul 17, 2019

  • expect argument after '-x'
  • fix declaration of xmlVar

- expect argument after '-x'
- fix declaration of xmlVar
@slm0n87 slm0n87 changed the title fix argument -x fix argument -x for devel Jul 17, 2019
@mcktr mcktr self-requested a review July 17, 2019 19:05
@mcktr mcktr added this to the 2.4 milestone Jul 17, 2019
@mcktr mcktr added the bug label Jul 17, 2019
@mcktr
Copy link
Owner

mcktr commented Jul 17, 2019

Hi,

thanks for your contribution. Unfortunately I stopped to maintain this check plugin, for the reasons please have a read here: #80.

I plan to release a last bugfix release of this check plugin. I want to merge both of your PRs in the last release. If you are interested in a actively maintained version of check plugin to monitor a Fritz!Box, please read my comment and/or have a look here: https://github.com/mcktr/check_fritz.

Thanks again for both of your pull requests, highly appreciated.

Best regards
Michael

@mcktr
Copy link
Owner

mcktr commented Jul 18, 2019

Thanks 👍

@mcktr mcktr merged commit 1991f7e into mcktr:master Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants