try to add secp256k1_support #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! Thanks for taking this on. Code looks pretty good at first glance, but before I dig further in I think this should be feature-gated (just like what we do with new crypto providers) since |
2 tasks
tarcieri
reviewed
Oct 29, 2020
| @@ -44,6 +44,7 @@ hacl-star = { version = "=0.0.11", optional = true } | |||
| rand = { version = "^0.5", optional = true } | |||
| ring = { version = "^0.13.0", optional = true } | |||
| x25519-dalek = { version = "^0.3", optional = true, default-features = false, features = ["std", "u64_backend"] } | |||
| secp256k1 = "0.11.3" | |||
There was a problem hiding this comment.
You might consider the pure Rust k256 crate from as an alternative here:
https://github.com/RustCrypto/elliptic-curves/tree/master/k256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Straightforward implementation of #37.