Unbind constraints 82998508 #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t the width and height include padding, borders, etc
…, eg.g for methods - see bugs/error2.html
…ents that need to be fired
[Fixes #79042844] setting box-sizing to border-box for sprites so that t...
…low timeout to be specified on the command line
It looks like my change to allow comments inside blocks addresses this, see 07caede 063d9b [Delivers #79004182]
[Delivers #79556166]
… are automatically sized to the size of their text to account for padding, now that box-sizing is border-box on views
…Timer. This reduces errors on Windows when exceptions are thrown. Sometimes, the first time I run phantomrunner.js I see errors like: RESOURCE ERROR: Operation canceled, URL: http://127.0.0.1:8080/classes/text.dre, File: error77941122.html These disappear if I run the test a second time.
This allows smoke/interactive/error79559324.html to work correctly. [Delivers #79559324]
[Delivers #79559324] for real
…ax for the text. I also moved the comments outside the class to prevent it from becoming part of the text. Also added smoke test.
…DD/TDD style expect syntax, plus additional assert apis
…e tests and expanded tests to cover setters.
…ror. The fix is that pointer-events should be "none" not "".
…laces where Layout should have been Layoot in preparation for eventual replacement of Layout with Layoot.
Autogenerate categories.json and guides.json
…RCE_ERROR messages on Windows (or other platforms) anymore. [Finishes #80307044]
Moved page inside runTest to avoid race conditions. I don't see RESOURCE...
[Delivers #83086612] don’t skip events for input text instances
[Delivers #79231296]
…n use simple variablelayout to accomplish this.'
Got layouts working with border/padding. Implemented percentage width, height, x and y on views with support for runtime changes.
Reworked border and padding so that runtime changes can be made.
…le. Also added support for camelcased or - character based css names in hackstyle.
Fix for #83266316. Made a single stylemap and inverted it for hackstyle....
mcarlson
force-pushed
the
unbind_constraints_82998508
branch
from
e2a99a2 to
0ecae52
Compare
Unbind constraints when a node is destroyed or a constraint is bound again with setConstraint() More comments, testing calling setAttribute() automatically unregisters constraints
mcarlson
force-pushed
the
unbind_constraints_82998508
branch
from
0ecae52 to
baf7b1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make binding and unbinding constraints work when an attribute with a constraint has another constraint applied, or a node is destroyed.