Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let cursor keys and PgUp/PgDown work as key combination on VCButtons #1584

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Pac72
Copy link

@Pac72 Pac72 commented Jun 13, 2024

As stated on #1443, PgUp, PgDown and cursor keys do not work when configured as key combination on VCButtons.
This happens because the QScrollArea hosting the controls intercepts these keys to move around the scroll area.

This change lets the mentioned keys pass through to the buttons when the user chooses them, but, of course, the keys chosen as key combinations will not be used to move around on the scroll area, since it would be way confusing to keep both functions.

Closes #1443

@yestalgia
Copy link
Contributor

Nice work - When a build becomes available I'll give it a test.

@mcallegari
Copy link
Owner

@Pac72 thanks for this.
For now I have just one comment. Please stick to the rest of the project code indentation: parenthesis go to new line.

@coveralls
Copy link

Coverage Status

coverage: 32.052% (+0.02%) from 32.034%
when pulling dcd746b on Pac72:issue-1443
into 3424652 on mcallegari:master.

@Pac72
Copy link
Author

Pac72 commented Jun 16, 2024

@mcallegari sure, sorry for that.
Now the indentation should be ok.

@qfulmina
Copy link
Contributor

Hi,
thanks for your contribution (indeed one I could make use of).

I tested a bit using the generated AppImage. As you state, it (unfortunately) only works for VCButtons (yet) and not for e.g. Cue Lists.

Speaking of which, PgUp and PgDown are consumed by Cue Lists if in focus up until the upper or lower end of the list is reached. Only then PgUp and PgDown bubble up and trigger any key combination event.

I think it would be best if Cue Lists were supported as well. (For e.g. being able to trigger the next Cue with PgDown etc.)

@qfulmina
Copy link
Contributor

Interestingly special keys like Space, Return, PgUp/PgDown, or Numbers are treated differently.

In the scope of inputting to a Duration Widget:

  • PgUp and PgDown never bubble up (not even when reaching the end).
  • Numbers are always consumed completely by the text inputs without ever bubbling up.
  • Space is always consumed completly by each input.
  • Return always bubbles through.

@Pac72
Copy link
Author

Pac72 commented Jun 16, 2024

Hi @qfulmina

I tested a bit using the generated AppImage. As you state, it (unfortunately) only works for VCButtons (yet) and not for e.g. Cue Lists.

@me guilty again. I did not understand the issue was general and so I specifically selected the VCButtons :-/

I think it would be best if Cue Lists were supported as well. (For e.g. being able to trigger the next Cue with PgDown etc.)

I'll try to cover also the other controls.

@Pac72
Copy link
Author

Pac72 commented Jun 18, 2024

Hi everyone.
I tried a different approach with #1586
If you like it better, this pull request can be closed.

@coveralls
Copy link

Coverage Status

coverage: 32.052% (+0.02%) from 32.034%
when pulling 782aec4 on Pac72:issue-1443
into 3424652 on mcallegari:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PgUp, PgDown and arrows don't work as keyboard shortcuts
5 participants