-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let cursor keys and PgUp/PgDown work as key combination on VCButtons #1584
base: master
Are you sure you want to change the base?
Conversation
Nice work - When a build becomes available I'll give it a test. |
@Pac72 thanks for this. |
@mcallegari sure, sorry for that. |
Hi, I tested a bit using the generated AppImage. As you state, it (unfortunately) only works for VCButtons (yet) and not for e.g. Cue Lists. Speaking of which, PgUp and PgDown are consumed by Cue Lists if in focus up until the upper or lower end of the list is reached. Only then PgUp and PgDown bubble up and trigger any key combination event. I think it would be best if Cue Lists were supported as well. (For e.g. being able to trigger the next Cue with PgDown etc.) |
Interestingly special keys like Space, Return, PgUp/PgDown, or Numbers are treated differently. In the scope of inputting to a Duration Widget:
|
Hi @qfulmina
@me guilty again. I did not understand the issue was general and so I specifically selected the VCButtons :-/
I'll try to cover also the other controls. |
Hi everyone. |
As stated on #1443, PgUp, PgDown and cursor keys do not work when configured as key combination on VCButtons.
This happens because the QScrollArea hosting the controls intercepts these keys to move around the scroll area.
This change lets the mentioned keys pass through to the buttons when the user chooses them, but, of course, the keys chosen as key combinations will not be used to move around on the scroll area, since it would be way confusing to keep both functions.
Closes #1443