Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed adding button monitor feedback for midi controllers #1103

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

ditcheshurt
Copy link
Contributor

I though it would be visually helpful for users of Midi controllers that have back-lit or otherwise feedback enabled button midi controllers to see what functions that have been activated by another function (monitoring) to create the same visual feedback you already have with the virtual console buttons.

I'm using an Akai APCMini for testing these changes and wanted to contribute to this amazing software and project.

@yestalgia
Copy link
Contributor

yestalgia commented Nov 22, 2023

This would fix the MIDI use case I mention here #1413

@yestalgia
Copy link
Contributor

https://www.qlcplus.org/forum/viewtopic.php?t=12839

Another request for this feature

@coveralls
Copy link

Coverage Status

coverage: 31.974% (+0.02%) from 31.958%
when pulling 863c0ae on ditcheshurt:master
into fa51c43 on mcallegari:master.

@mcallegari mcallegari merged commit 29dfa14 into mcallegari:master Feb 5, 2024
7 checks passed
mcallegari added a commit that referenced this pull request Feb 5, 2024
@mcallegari
Copy link
Owner

I finally merged this and found a few errors:

  • the word "Value" was removed from labels (luckily I saw this)
  • the monitoring spinbox was visible also for non button widgets

Now it's fixed. Thanks for contributing.

@yestalgia
Copy link
Contributor

Huge improvement! Thanks guys :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants