Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 30 spilt scm #32

Merged
merged 52 commits into from
Dec 7, 2023
Merged

Issue 30 spilt scm #32

merged 52 commits into from
Dec 7, 2023

Conversation

ChristophLHR
Copy link
Member

@ChristophLHR ChristophLHR commented Nov 6, 2023 •
edited by ColdIV
Loading

resolves #30
resolves #33

@ChristophLHR ChristophLHR self-assigned this Nov 6, 2023
@ColdIV ColdIV added the enhancement New feature or request label Nov 6, 2023
@ColdIV ColdIV mentioned this pull request Nov 6, 2023
Closed
@ColdIV
Copy link
Member

ColdIV commented Dec 3, 2023 •
edited
Loading

We should also resolve this other draft as part of this PR: #20

Open todos:

  • implement installer (in repo and pastebin)
  • test everything in game (complete functionality) done, works
  • duplicate function "refreshRepoScripts", one has to go
  • function downloadURL is never called, could be used in git download and maybe later to download from any url

@ColdIV
Copy link
Member

ColdIV commented Dec 7, 2023

resolves #19

@ColdIV ColdIV marked this pull request as ready for review December 7, 2023 19:15
ColdIV
ColdIV approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@ColdIV ColdIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ChristophLHR ChristophLHR merged commit 6c14ecd into master Dec 7, 2023
2 checks passed
@ColdIV ColdIV mentioned this pull request Dec 7, 2023
Closed
@ColdIV ColdIV deleted the Issue-30-Spilt-SCM branch December 7, 2023 19:42
@ColdIV ColdIV mentioned this pull request Dec 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColdIV ColdIV ColdIV approved these changes

Assignees

@ChristophLHR ChristophLHR

Labels
enhancement New feature or request
Projects
All Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SCM remove <programname> does not remove the Script, only the "caller" in the root Spilt SCM
2 participants
@ChristophLHR @ColdIV