Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 4 function to read shp file with Z value #53

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

wemamawe
Copy link

dear sir:
i very thanks that you write this to read shape file, it help me a lot.
when i use this to read 3D(x,y,z) shape file, it just return two dimension x and y, so i read you raw code carefully, and then i write some code to read Z value based on yours.
recently i find some person get in to the same trouble like me, so i want to upload my code, and share to them.
I hope you can accept my code, thanks again.
image
image

your follower, wema

@m-schuetz
Copy link

Should typenames in shp/polylinez.js be "LineString" or "LineStringZ" ?

@wemamawe
Copy link
Author

wemamawe commented Dec 6, 2018

i should explain this , there are many types in shape file like las format, so as the definition of ESRI, the type name should be LineStringZ, but for using easier, I set the type name as LineString.
shapetype

wemamawe referenced this pull request in potree/potree Jan 25, 2019
Adding PolyLineZ support to shapefiles.
@rowanwins
Copy link

Just a quick comment on this PR.

The GeoJSON spec does not have seperate types for Point and PointZ (and the same for other geoemtry types). If this lib is attempting to align to the geojson spec then bits like this would need some tweaking.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants