Add Robot.react to Hubot >= v3.0.0 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 5, 2017 15:20
At some point Node.js started emitting this warning from
`tests/integration-test.js`:
(node:85642) [DEP0013] DeprecationWarning: Calling an asynchronous
function without callback is deprecated.
By following the instructions in the Node.js API docs, I was able to
emit the stack trace pinpointing this `fs.write` call as the offender:
https://nodejs.org/api/process.html#process_event_warning
Addresses the issue described in #15. In short, hubot-test-helper v1.8.0 depends on hubot-v3.0.0, both are rewrites from CoffeeScript to ES2015, and consequently hubot-slack adds Robot.react to a CoffeeScript- compatible wrapper function, leading to smoke and integration test failures. The implementation of slackapi/hubot-slack#429 (CoffeeScript-to-ES2015 rewrite) should include a fix that will eliminate the need for this workaround.
|
Changes Unknown when pulling a84ca77 on es2015-fix into ** on master**. |
1 similar comment
|
Changes Unknown when pulling a84ca77 on es2015-fix into ** on master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issue described in #15. In short, hubot-test-helper v1.8.0 depends on hubot-v3.0.0, both are rewrites from CoffeeScript to ES2015, and consequently hubot-slack adds Robot.react to a CoffeeScript-compatible wrapper function, leading to smoke and integration test failures.
The implementation of slackapi/hubot-slack#429 (CoffeeScript-to-ES2015 rewrite) should include a fix that will eliminate the need for this workaround.
Also adds a callback to fix the
DeprecationWarningthat Node.js started emitting fromtests/integration-test.js:By following the process event warning instructions in the Node.js API docs, I was able to emit the stack trace pinpointing the
fs.writecall as the offender.