SQL, API, and rate-limiting improvements #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can see if we've already boosted a toot via the database, so it is possible to have postgres take care of this for us.
one less thing to configure!
I used ceil() to make things a little cleaner-looking, but it shifted the number of faves required up by 1. (e.g. if the avg is 3.141, this patch returns the fave threshold back to 4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of caching, uses a subquery to determine if the toot has already been boosted by ourself.
Snags our current account ID from the API so we can do the aforementioned determination.
Also puts a LIMIT clause on the query so that we only boost a certain number of toots per run (default: 2). This particular adjustment was courtesy of me forgetting to restart Ambassador after a reboot...
This pull request is a bit of a congealed mess. I, or someone else, could split it into a couple distinct patches without too much effort I think.