Fix for cell value-wrapping and IndexOutOfBounds on unmatching loop tokens #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tape is supposedly working on bytes, therefore the cell values should never end up with values less than zero or greater than 255. While the values can be capped, it is much better to implement value-wrapping. Brainfuck.Run() now accepts two additional, optional parameters for the in/out streams, instead of assuming Console streams. Minor refactoring of Tape class. Added a UnitTest project with a few BFLib Brainfuck tests, also demonstrating a use-case for the tape cell value-wrapping.
Some invalid Brainfuck code with an unequal amount loop start/end tokens will lead to an IndexOutOfRange exception. This fix will ensure that the program does not attempt to traverse beyond the code range and will stop execution silently instead. Some implementations of BF refuse to run the code immediately upon detecting it as invalid. This currently does not perform any pre-run checks, and as such some portions of the code may finish executing by the time the loop is encountered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.