Skip to content

Commit

Permalink
revert change to PendingEnvelopes::addSCPQuorumSet
Browse files Browse the repository at this point in the history
change introduced in d1b33a4 was wrong
hash was the hash of a quorum set not the hash of a node
  • Loading branch information
MonsieurNicolas committed Apr 26, 2018
1 parent d025842 commit 2ee4e2e
Showing 1 changed file with 1 addition and 10 deletions.
11 changes: 1 addition & 10 deletions src/herder/PendingEnvelopes.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -66,16 +66,7 @@ PendingEnvelopes::addSCPQuorumSet(Hash hash, const SCPQuorumSet& q)
CLOG(TRACE, "Herder") << "Add SCPQSet " << hexAbbrev(hash);

SCPQuorumSetPtr qset(new SCPQuorumSet(q));
if (mQsetCache.exists(hash))
{
// force recomputation of transitive quorum information as it may change
// "not in quorum" into "in quorum".
// the "quorum -> not in quorum" is similar to the case of a new quorum
// set, where the only thing it can do is turn
// a "maybe" (true) into "no" (false) which doesn't matter within
// a round (clear will happens regardless when the slot is externalized)
mNodesInQuorum.clear();
}
mNodesInQuorum.clear();
mQsetCache.put(hash, qset);

mQuorumSetFetcher.recv(hash);
Expand Down

0 comments on commit 2ee4e2e

Please sign in to comment.