PHAPI, TOKOPT, CHROPT and SAMTO Fixes
#628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should read the _LAST_ character in the string, not the first.
Fixes GE Command Parsing, Tests still pass
- Fixes GE
- Fixes 3 Operand IMUL Operations - Unit Tests for IMUL
- Enhanced 3 Operand `IMUL` to use width specific helper functions - Properly Set OF/CF on Overflow
paladine
approved these changes
Jul 17, 2024
- Verified Unit Tests + Results against DOSBox
paladine
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHROPTto use the last character in the MSG file valueTOKOPTto use the last word in the MSG file valueTOKOPTUnit TestsSAMETOto use the C# equivalent of.StartsWith()vs..Contains()PHAPI0x10 to beDosAllocSeg()(this will break another module I forget, but is correct for Galactic Empire)IMULOperations