-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Pbp job agent #47
base: main
Are you sure you want to change the base?
add Pbp job agent #47
Conversation
Will test until it works!
Added test yamls
Good stopping point.
end of day commit
End of day commit
Job agent seems to work on linux
pbp-job-agent seems to be working!
Added some extra log stuff
Improved argument structure
Added multiprocessing
Multiprocessing works on windows and linux.
Fixed some logging.
Added comments
Ran a ruff format on job agent
Ran another ruff
Made some fixes picked up by CI
Fixed even more errors picked up by CI
A bug of extra stuff and some improved test structuring.
Attempt to fix merge
Attempt to fix merge
Small updates
Added Samaras Files
Got NRS with job agent partially working
NRS is compatible with the pbp-job-agent.
updated files
Attempting to fix logs
So I cant use a non global logger so I just re-added the logger in the run().
This was a testing artifact.
Ran a ruff format pbp
fixed sountrap issue
fixed sountrap issue
Sorry
Fixed things using the path library more often.
0d75e19
to
081fbb7
Compare
Fixed underscore issue.
Got subset-to placed in the job-agent
Removed artifact print statements.
Ran a ruff format .
Hi @spacetimeengineer - Seems like there's a failed check. More in general, when do you think you will be completing your changes (and providing instructions) so @danellecline , @ryjombari and I can plan on reviewing/testing? If possible, we would like to advance that review exercise in preparation for our meeting this Thursday. Thanks! |
@spacetimeengineer – I checked out your branch in my local dev env.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(just making github happy) I indicated some initial changes in my previous comment.
@spacetimeengineer – We have just updated the main branch with incorporation of the end-user documentation setup and markdown sources (which were previously maintained in a separate repo). It would be great if you could also add some documentation for the new job agent in that setup, which is based on mkdocs, with mkdocs-material. In a nutshell, under
Thanks for considering. |
Added a new pattern
Added another regrex.
Attempting a fix and to debug Nonetype error.
I am sending this PR as a formality after our last demo. I am not sure how to set it up as a branch on your repo. I developed a job agent utility for SOUNDTRAP and NRS, incorporating new datetime formats and regex patterns. Most of the code is new and doesn't interfere with your existing work. I only took the liberty of modifying the Windows-based routines in your code base which I improved upon by utilizing the Path library in places where it belonged.