-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/239 add partij identificatoren on partij creation #321
base: master
Are you sure you want to change the base?
Feature/239 add partij identificatoren on partij creation #321
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One or two conceptual points to consider, see the comments.
src/openklant/components/klantinteracties/api/serializers/partijen.py
Outdated
Show resolved
Hide resolved
src/openklant/components/klantinteracties/api/tests/test_partijen.py
Outdated
Show resolved
Hide resolved
src/openklant/components/klantinteracties/api/tests/test_partijen.py
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #321 +/- ##
==========================================
+ Coverage 97.10% 97.21% +0.11%
==========================================
Files 179 182 +3
Lines 8671 9061 +390
==========================================
+ Hits 8420 8809 +389
- Misses 251 252 +1 ☔ View full report in Codecov by Sentry. |
Fixes #239
// POST /partijen
allow to pass a list ofpartijIdentificatoren
:partij_identificator
orUUID
// PUT /partijen
allow to pass a list ofpartijIdentificatoren
:partij_identificator
obj orUUID
// PUT /partijen
3 cases:
**
For updating
partij-identificatoren
, this is not the right endpoint, because the edpoint/partij-identificatoren/
remains accessible for their operation.**