[#2966] Refactor logic for registering contactmomenten in eSuite #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi-sigma
force-pushed
the
task/2966-openklant2-zaak-questions
branch
3 times, most recently
from
c6d86d2 to
3928ecc
Compare
pi-sigma
changed the title
pi-sigma
force-pushed
the
task/2966-openklant2-zaak-questions
branch
3 times, most recently
from
c419675 to
65f542b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1552 +/- ##
===========================================
+ Coverage 94.23% 94.24% +0.01%
===========================================
Files 1070 1073 +3
Lines 39413 39532 +119
===========================================
+ Hits 37141 37258 +117
- Misses 2272 2274 +2 ☔ View full report in Codecov by Sentry. |
pi-sigma
force-pushed
the
task/2966-openklant2-zaak-questions
branch
from
65f542b to
58976f2
Compare
pi-sigma
force-pushed
the
task/2966-openklant2-zaak-questions
branch
4 times, most recently
from
a2d86c1 to
12267c4
Compare
swrichards
requested changes
Jan 20, 2025
pi-sigma
force-pushed
the
task/2966-openklant2-zaak-questions
branch
from
12267c4 to
9e2c883
Compare
swrichards
reviewed
Jan 21, 2025
| class Migration(migrations.Migration): | ||
|
|
||
| dependencies = [ | ||
| ("openklant", "0018_rename_openklantconfig_esuiteklantconfig_and_more"), |
There was a problem hiding this comment.
I think this needs to be dependent on src/open_inwoner/openklant/migrations/0020_add_more_help_texts_to_openklant2_config.py?
pi-sigma
force-pushed
the
task/2966-openklant2-zaak-questions
branch
from
9e2c883 to
4a28798
Compare
pi-sigma
force-pushed
the
task/2966-openklant2-zaak-questions
branch
from
4a28798 to
913b67a
Compare
swrichards
reviewed
Jan 22, 2025
Comment on lines
8
to
10
| dependencies = [ | ||
| ("openklant", "0019_alter_klantensysteemconfig_primary_backend"), | ||
| ] |
There was a problem hiding this comment.
There was a problem hiding this comment.
You're right, I mixed up the order (0020_add_more... is already in develop but there's no logical dependency between the migrations).
added 3 commits
January 22, 2025 15:38
- move relevant fields from ESuiteKlantConfig to global
KlantenSysteemConfig so they can be used for OpenKlant2
as well
pi-sigma
force-pushed
the
task/2966-openklant2-zaak-questions
branch
from
913b67a to
38658c4
Compare
swrichards
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for adding support for registering questions with OpenKlant2, the existing logic for registering contactmomenten in the eSuite is refactored.
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/2966