Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing authorizations app for commonground-api-common #70

Closed
wants to merge 1 commit into from
Closed

Add missing authorizations app for commonground-api-common #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions open_api_framework/conf/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@
"csp",
"corsheaders",
"vng_api_common",
"vng_api_common.authorizations",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SonnyBA come to think of it, I'm actually not sure if all components use this (e.g. Objects/Objecttypes), so wouldn't it be better to add this only to the components that need it? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open-zaak (commonground-api-common used the middleware class from this project), Open-Klant and Open-Notificaties use the authorizations app from commonground-api-common.

I think the migrations authorizations migrations currently are recognized (even if the app is not installed) because the middleware.py imports them. It should be easily fixed though whenever we move the authorization related middleware to the authorizations app. This probably requires a new release though of OAF (because all projects pull in commonground-api-common through OAF) and commonground-api-common.

The current suggested fix is probably a bit less work but is also the uglier solution. @Coperh @stevenbal which option would you prefer?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be best to indeed move the middleware to the authorizations app. I think this also relates to #67, we should make these dependencies should be optional at some point probably

"notifications_api_common",
"drf_spectacular",
"rest_framework",
Expand Down
Loading