-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github action to check if OAF is Up to Date #443
Conversation
31c27d7
to
8c66769
Compare
Can see the PRs it makes here: https://github.com/Coperh/objects-api/pulls (have it set to 2 PRs since one was queued forever |
Let's discuss it I see the created PR for python dependencies updates libraries which are included in open-api-framework @alextreme @joeribekker what do you think? |
I see your point and I largely agree. Although registrations have some deps that are outside the OAF scope and also require updating in these components. Best solution would be to place the OAF-deps out of scope (but thats probably not possible) and let that be handled in the OAF-repo. I'm still interested to see the effects. Dependabot could update OAF and conclude that because OAF was updated, other libraries are then also updated and dont need individual updating.
No clue but @Coperh can probably answer that. |
@annashamray You can allow dependabot to only update certain libraries:
You can do the same with exclude |
@joeribekker @Coperh So let's try using it with current implementation. |
@Coperh Am I correct that with the current configuration a PR like this (Coperh#2) would be created for Python dependencies? If that's correct then I have a question. In this PR only |
Dependabot seems very inconsistent. Sometimes its all in one PR like Coperh#13, sometimes in separate PRs It does not really work with the current structure since dev.txt does not inherit from base |
8c66769
to
21c1686
Compare
@annashamray Completely changed it to an action that checks if compile-dependencies changes anything. I think I can remove the |
Example in my personal repo: https://github.com/Coperh/objects-api/actions/runs/10902015010/job/30252978244 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please rename the PR, because it's not about dependabot anymore?
fixes: maykinmedia/open-api-framework#44