-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ - feat: implemented useFormDialog hook #140
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -98,6 +98,8 @@ export const Prompt: Story = { | |
"Annuleren", | ||
args.onConfirm, | ||
args.onCancel, | ||
undefined, | ||
true, | ||
) | ||
} | ||
> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,123 @@ | ||
import React, { useContext, useEffect } from "react"; | ||
|
||
import { Form, FormProps, ModalProps, P } from "../../components"; | ||
import { ModalServiceContext } from "../../contexts"; | ||
import { AttributeData, FormField } from "../../lib"; | ||
import { useDialog } from "./usedialog"; | ||
|
||
/** | ||
* Returns a function which, when called: shows a form dialog with a | ||
* confirmation callback and an optional cancellation callback. | ||
*/ | ||
export const useFormDialog = () => { | ||
const dialog = useDialog(); | ||
|
||
/** | ||
* Shows a prompt dialog with a confirmation callback and an optional | ||
* cancellation callback. | ||
* @param title | ||
* @param message | ||
* @param fields | ||
* @param labelConfirm | ||
* @param labelCancel | ||
* @param onConfirm | ||
* @param onCancel | ||
* @param modalProps | ||
* @param formProps | ||
* @param autofocus | ||
*/ | ||
const fn = ( | ||
title: string, | ||
message: React.ReactNode, | ||
fields: FormField[], | ||
labelConfirm: string, | ||
labelCancel: string, | ||
onConfirm: (data: AttributeData) => void, | ||
onCancel?: () => void, | ||
modalProps?: Partial<ModalProps>, | ||
formProps?: FormProps, | ||
autofocus?: boolean, | ||
) => { | ||
dialog( | ||
title, | ||
<> | ||
{typeof message === "string" ? <P>{message}</P> : message} | ||
<PromptForm | ||
message={message} | ||
fields={fields} | ||
labelConfirm={labelConfirm} | ||
labelCancel={labelCancel} | ||
onConfirm={onConfirm} | ||
onCancel={onCancel} | ||
formProps={formProps} | ||
autofocus={autofocus} | ||
/> | ||
</>, | ||
undefined, | ||
{ allowClose: false, ...modalProps }, | ||
); | ||
}; | ||
|
||
return fn; | ||
}; | ||
|
||
const PromptForm = ({ | ||
fields, | ||
labelConfirm, | ||
labelCancel, | ||
onConfirm, | ||
onCancel, | ||
formProps, | ||
autofocus = false, | ||
}: { | ||
message: React.ReactNode; | ||
fields: FormField[]; | ||
labelConfirm: string; | ||
labelCancel: string; | ||
onConfirm: (data: AttributeData) => void; | ||
onCancel?: () => void; | ||
formProps?: FormProps; | ||
autofocus?: boolean; | ||
}) => { | ||
const { setModalProps } = useContext(ModalServiceContext); | ||
|
||
useEffect(() => { | ||
if (!autofocus) return; | ||
// Delay the focus slightly to ensure modal and form are fully rendered | ||
const timer = setTimeout(() => { | ||
// We focus a form element, and if none are found, we focus the submit button, and otherwise none | ||
const formElement: HTMLFormElement | null = document.querySelector( | ||
"form input , form textarea , form select , form button[type=submit]", | ||
); | ||
if (formElement) { | ||
formElement.focus(); | ||
} | ||
}, 100); | ||
|
||
return () => clearTimeout(timer); | ||
}, []); | ||
|
||
return ( | ||
<Form | ||
fields={fields} | ||
labelSubmit={labelConfirm} | ||
secondaryActions={[ | ||
{ | ||
children: labelCancel, | ||
type: "button", | ||
variant: "secondary", | ||
onClick: () => { | ||
setModalProps({ open: false }); | ||
onCancel?.(); | ||
}, | ||
}, | ||
]} | ||
validateOnChange={true} | ||
onSubmit={(_, data) => { | ||
setModalProps({ open: false }); | ||
onConfirm(data); | ||
}} | ||
{...formProps} | ||
/> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The public interface doesn't doesn't to change bacause of this refactor right? It just implements the behaviour of useFormDialog for code reuse?