Issue/dialog autofocus #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xaohs
force-pushed
the
issue/dialog-autofocus
branch
from
7e2eb30 to
c601399
Compare
| undefined, | ||
| { allowClose: false, ...modalProps }, | ||
| ); | ||
| }; | ||
|
|
||
| return fn; | ||
| }; | ||
|
|
||
| const PromptForm = ({ |
There was a problem hiding this comment.
Is there any reason why an additional component is introduced over using the effect directly on the hook (might work as well I think?)
I like to keep changes as minimal as possible especially considering that a new similar hook useFormDialog may be introduced (see: OAB).
There was a problem hiding this comment.
Yeah, a hook cannot be used in the function of that component like that, as it defies the rules of react hooks
There was a problem hiding this comment.
Ah I think you're correct, were acting on the returned function instead of the hook. I sill think this could be a nice moment to merge this with useFormDialog though so lets discuss further.
|
Closed in favor of #140 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.