Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uninitialized string offset in UnnecessaryNamespaceUsage, fixes #212 #213

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

xalopp
Copy link
Contributor

@xalopp xalopp commented Dec 14, 2024

Type of PR

  • Bugfix
  • New Feature
  • Other (explain):

Breaking changes

  • Yes, this is a breaking change

Description

fix for issue #212 .

@xalopp xalopp force-pushed the fix_empty_class_name branch 2 times, most recently from 2832a00 to 20da5f6 Compare December 15, 2024 12:38
@xalopp xalopp changed the title Fix phpcbf crash in UnnecessaryNamespaceUsageSniff when class name is empty, fixes #212 Fixes Uninitialized string offset in UnnecessaryNamespaceUsage, fixes #212 Dec 15, 2024
@xalopp xalopp force-pushed the fix_empty_class_name branch from 20da5f6 to 96d6a09 Compare December 15, 2024 12:49
@xalopp xalopp changed the title Fixes Uninitialized string offset in UnnecessaryNamespaceUsage, fixes #212 Fix Uninitialized string offset in UnnecessaryNamespaceUsage, fixes #212 Dec 15, 2024
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a31a9e5) to head (96d6a09).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #213   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       150       151    +1     
===========================================
  Files              8         8           
  Lines            669       671    +2     
===========================================
+ Hits             669       671    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmoll mmoll closed this Dec 15, 2024
@mmoll mmoll reopened this Dec 15, 2024
@xalopp xalopp force-pushed the fix_empty_class_name branch 2 times, most recently from 96d6a09 to 5643bfc Compare December 15, 2024 18:48
@xalopp xalopp force-pushed the fix_empty_class_name branch from 5643bfc to bfbe6cf Compare December 16, 2024 09:19
@xalopp xalopp changed the title Fix Uninitialized string offset in UnnecessaryNamespaceUsage, fixes #212 Fix uninitialized string offset in UnnecessaryNamespaceUsage, fixes #212 Dec 16, 2024
@mmoll mmoll merged commit 21e8808 into mayflower:master Dec 16, 2024
39 checks passed
@mmoll
Copy link
Contributor

mmoll commented Dec 16, 2024

merged, merci @xalopp!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants