Fix Windows extension build

maxmind · Nov 3, 2023 · f7b3bed · f7b3bed
1 parent 7c3a93b
commit f7b3bed
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -11,9 +11,7 @@ jobs:
 
     strategy:
       matrix:
-        # We don't test on Windows currently due to issues
-        # build libmaxminddb there.
-        platform: [macos-latest, ubuntu-latest]
+        platform: [macos-latest, ubuntu-latest, windows-latest]
         python-version: [3.8, 3.9, "3.10", 3.11, 3.12]
 
     name: Python ${{ matrix.python-version }} on ${{ matrix.platform }}

diff --git a/extension/maxminddb.c b/extension/maxminddb.c
@@ -1,11 +1,16 @@
 #define PY_SSIZE_T_CLEAN
 #include <Python.h>
+#ifdef MS_WINDOWS
+#include <winsock2.h>
+#include <ws2tcpip.h>
+#else
 #include <arpa/inet.h>
-#include <maxminddb.h>
 #include <netinet/in.h>
-#include <structmember.h>
 #include <sys/socket.h>
 #include <unistd.h>
+#endif
+#include <maxminddb.h>
+#include <structmember.h>
 
 #define __STDC_FORMAT_MACROS
 #include <inttypes.h>