Skip to content

Commit

Permalink
Separate out system libmaxminddb into separate workflow
Browse files Browse the repository at this point in the history
  • Loading branch information
oschwald committed Nov 3, 2023
1 parent 7df6b0a commit 79e3e43
Show file tree
Hide file tree
Showing 2 changed files with 59 additions and 22 deletions.
58 changes: 58 additions & 0 deletions .github/workflows/test-libmaxminddb.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
name: Python tests (system libmaxminddb)

on:
push:
pull_request:
schedule:
- cron: '3 15 * * SUN'

jobs:
build:

strategy:
matrix:
# We don't test on Windows currently due to issues
# build libmaxminddb there.
platform: [macos-latest, windows-latest, ubuntu-latest]
python-version: [3.8, 3.9, "3.10", 3.11, 3.12]

name: Python ${{ matrix.python-version }} on ${{ matrix.platform }}
runs-on: ${{ matrix.platform }}

steps:
- name: Checkout
uses: actions/checkout@v4
with:
submodules: true

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}

- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install setuptools tox tox-gh-actions wheel
- name: Install libmaxminddb
run: sudo apt install libmaxminddb-dev
if: matrix.platform == 'ubuntu-latest'

- name: Build with Werror and Wall
run: python setup.py build
env:
CFLAGS: "-Werror -Wall -Wextra"
MAXMINDDB_REQUIRE_EXTENSION: 1

- name: Install libmaxminddb
run: brew install libmaxminddb
if: matrix.platform == 'macos-latest'

- name: Test with tox (system libmaxminddb)
run: tox
env:
MAXMINDDB_REQUIRE_EXTENSION: 1
MAXMINDDB_USE_SYSTEM_LIBMAXMINDDB: 1
MM_FORCE_EXT_TESTS: 1
23 changes: 1 addition & 22 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,31 +33,10 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install setuptools tox tox-gh-actions wheel
- name: Build with Werror and Wall
run: python setup.py build
env:
CFLAGS: "-Werror -Wall -Wextra"
MAXMINDDB_REQUIRE_EXTENSION: 1
pip install tox tox-gh-actions
- name: Test with tox (vendored libmaxminddb)
run: tox
env:
MAXMINDDB_REQUIRE_EXTENSION: 1
MM_FORCE_EXT_TESTS: 1

- name: Install libmaxminddb
run: sudo apt install libmaxminddb-dev
if: matrix.platform == 'ubuntu-latest'

- name: Install libmaxminddb
run: brew install libmaxminddb
if: matrix.platform == 'macos-latest'

- name: Test with tox (system libmaxminddb)
run: tox
env:
MAXMINDDB_REQUIRE_EXTENSION: 1
MAXMINDDB_USE_SYSTEM_LIBMAXMINDDB: 1
MM_FORCE_EXT_TESTS: 1

0 comments on commit 79e3e43

Please sign in to comment.