Merge pull request #117 from maxmind/greg/test-on-macos

Run tests on macOS
maxmind · Jul 18, 2023 · 579769d · 579769d
2 parents b511290 + 1f77d61
commit 579769d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -11,9 +11,9 @@ jobs:
 
     strategy:
       matrix:
-        # We don't test on Windows and macOS currently due to issues
+        # We don't test on Windows currently due to issues
         # build libmaxminddb there.
-        platform: [ubuntu-latest]
+        platform: [macos-latest, ubuntu-latest]
         python-version: [3.7, 3.8, 3.9, "3.10", 3.11]
 
     name: Python ${{ matrix.python-version }} on ${{ matrix.platform }}
@@ -27,6 +27,11 @@ jobs:
 
       - name: Install libmaxminddb
         run: sudo apt install libmaxminddb-dev
+        if: matrix.platform == 'ubuntu-latest'
+
+      - name: Install libmaxminddb
+        run: brew install libmaxminddb
+        if: matrix.platform == 'macos-latest'
 
       - name: Set up Python ${{ matrix.python-version }}
         uses: actions/setup-python@v4

diff --git a/HISTORY.rst b/HISTORY.rst
@@ -3,6 +3,12 @@
 History
 -------
 
+2.4.1
+++++++++++++++++++
+
+* The multiprocessing test now explicitly uses ``fork``. This allows it
+  to run successfully on macOS. Pull request by Theodore Ni. GitHub #116.
+
 2.4.0 (2023-06-28)
 ++++++++++++++++++
-Original file line number
+Diff line change
@@ Expand Up / @@ -3,6 +3,12 @@ @@
     History
     -------
+.4.1
+    ++++++++++++++++++
+    * The multiprocessing test now explicitly uses ``fork``. This allows it
+      to run successfully on macOS. Pull request by Theodore Ni. GitHub #116.
 .4.0 (2023-06-28)
     ++++++++++++++++++
@@ Expand Down @@