Bugfix for racy crash on opening bad serial port #12122
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce: on linux, try to connect to an existing /dev/ttySX that is not a valid serial port (preexisting ttys?)
Crash happens like this:
Simply moves the connection of signals (readyRead and errorOccurred) until the serial port's configuration is finished.
Note: I'm guessing that should data arrive in between port opening and connection of the readyRead() signal, it does not matter since it's the event loop stuff that triggers the readyRead()