AnalyzeView: Download Logs in Separate Thread #11980
Draft
+675
−666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTRamsey
force-pushed
the
dev-analyzeview-logdownload
branch
from
97dd585
to
064d990
Compare
HTRamsey
force-pushed
the
dev-analyzeview-logdownload
branch
2 times, most recently
from
f83bbfa
to
dd21add
Compare
HTRamsey
force-pushed
the
dev-analyzeview-logdownload
branch
from
dd21add
to
2f036e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4656
Also re-enable unit test
TODO: Convert QtConcurrent to QThread due to QTimer threading