Remote id fronted: hide all indicators if RID comms is not healthy: #10704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does it make sens to communicate by text what is happening? I get that red is "danger" or "something is broken" but I don't get that a device is missing from that. |
All this remote id feature depends on a device being detected so it makes sense to not show the rest of the flags until a healthy connection has been detected. Also change label from RID COMMS to NOT CONNECTED when there is no RID connection, so it is more descriptive to the user.
Davidsastresas
force-pushed
the
master-PR/Fix_RID_Indicators
branch
from
0180769 to
eefa2bd
Compare
|
@booo It makes a lot of sense, I hadn't thought about it. I modified it so now when there is no connection, the label shows "NOT CONNECTED" instead of "RID COMMS" just with red background. It looks as follows:
I squashed and extended the commit comment. Let me know if this looks good now. Thanks for the review! |
|
Looks good now. |
|
I tested it with both ArduPilot and PX4. Looks indeed good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All this remote id feature depends on a device being detected so it makes sense to not show the rest of the flags until a healthy connection has been detected. Now it looks like this until we have healthy connection with RID device ( arm status message received ):
It addresses the issues mentioned here #10654.