Skip to content

Commit

Permalink
handleslack: ignore messages with unknown type and hidden flag
Browse files Browse the repository at this point in the history
  • Loading branch information
tulir committed Jul 22, 2024
1 parent b7f07ff commit c7db926
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion pkg/connector/handleslack.go
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,8 @@ func (s *SlackClient) wrapEvent(ctx context.Context, rawEvt any) (bridgev2.Remot
Str("message_ts", evt.Timestamp).
Str("message_id", string(meta.ID)).
Str("message_sender", sender).
Str("subtype", evt.SubType)
Str("subtype", evt.SubType).
Bool("hidden", evt.Hidden)
}
wrapped = &SlackMessage{
SlackEventMeta: &meta,
Expand Down Expand Up @@ -458,7 +459,14 @@ func (s *SlackMessage) GetType() bridgev2.RemoteEventType {
case slack.MsgSubTypeMessageReplied, slack.MsgSubTypeGroupJoin, slack.MsgSubTypeGroupLeave,
slack.MsgSubTypeChannelJoin, slack.MsgSubTypeChannelLeave:
return bridgev2.RemoteEventUnknown
case "", slack.MsgSubTypeMeMessage, slack.MsgSubTypeBotMessage, slack.MsgSubTypeThreadBroadcast, "huddle_thread":
// Known types
return bridgev2.RemoteEventMessage
default:
// For unknown types with the hidden flag, don't bridge
if s.Data.Hidden {
return bridgev2.RemoteEventUnknown
}
return bridgev2.RemoteEventMessage
}
}
Expand Down

0 comments on commit c7db926

Please sign in to comment.