Fix native library linking #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattprecious
force-pushed
the
mattp/2023-10-27/paths
branch
from
28cdd36 to
976306d
Compare
This was only working for local development since project paths were being included in the libraries when building. Pointing rpath to "@loader_path" tells them to look in their relative directory when loading other libraries. The manual loading of the additional libraries was completely unnecessary.
JakeWharton
approved these changes
Oct 27, 2023
mattprecious
force-pushed
the
mattp/2023-10-27/paths
branch
from
976306d to
079b6de
Compare
|
Not good enough. Going to investigate static linking instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was only working for local development since project paths were
being included in the libraries when building. Pointing rpath to
"@loader_path" tells them to look in their relative directory when
loading other libraries.
The manual loading of the additional libraries was completely
unnecessary.