Upload distribution on CI builds #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
approved these changes
Oct 27, 2023
mattprecious
force-pushed
the
mattp/2023-10-27/upload
branch
from
d896914 to
3a2e48c
Compare
JakeWharton
reviewed
Oct 27, 2023
.github/workflows/build.yaml
Outdated
Comment on lines
103
to
104
| name: st | ||
| path: ./build/distributions/st.zip |
There was a problem hiding this comment.
This might double zip :(
There was a problem hiding this comment.
Yep: https://github.com/actions/upload-artifact#zipped-artifact-downloads
Do the installDist output dir so it gets zipped once
There was a problem hiding this comment.
Hmm, interesting. My computer must have double-extracted then because it was invisible to me. Homebrew also seems to double-extract.
mattprecious
force-pushed
the
mattp/2023-10-27/upload
branch
from
3a2e48c to
1dde5ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.