Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/language service plugin #154

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Feature/language service plugin #154

wants to merge 4 commits into from

Conversation

ivan-demchenko
Copy link

@ivan-demchenko ivan-demchenko commented Feb 6, 2023 •
edited
Loading

This is just a draft PR.
Closes #51

@changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: fc27b02

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ts-error-translator ❌ Failed (Inspect) Feb 7, 2023 at 7:54PM (UTC)

@ivan-demchenko
Copy link
Author

First results
image

ivan-demchenko
ivan-demchenko commented Feb 7, 2023
View reviewed changes
packages/language-service-plugin/src/index.ts
@@ -0,0 +1,53 @@
import { parseErrors } from '@total-typescript/error-translation-engine';
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattpocock I'm not sure if this is the right function to import here

ivan-demchenko
ivan-demchenko commented Feb 8, 2023
View reviewed changes
packages/engine/package.json
@@ -2,11 +2,12 @@
"name": "@total-typescript/error-translation-engine",
"version": "1.0.3",
"license": "MIT",
"main": "./src/index.ts",
"types": "./src/index.ts",
"main": "./out/index.js",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattpocock I needed this change to make plugin bundling work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

As a "Language Service Plugin" to have broad support for IDEs besides vscode
2 participants
@ivan-demchenko @raqystyle