Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also remove any JS after a comment in the form of /*DEV*/ #213

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tetrode
Copy link

@tetrode tetrode commented Nov 6, 2017

Using this to log to the console during development, e.g.
/DEV/ console.log("debug information");
Anything after the /DEV/ string is removed on minification.

Using this to log to the console during development, e.g. 
/*DEV*/ console.log("debug information");
Anything after the /*DEV*/ string is removed on minification.
@codecov-io
Copy link

Codecov Report

Merging #213 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #213   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines         493    494    +1     
=====================================
+ Hits          493    494    +1
Impacted Files Coverage Δ
src/JS.php 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21084eb...ee5b01a. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Nov 6, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@4762aed). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #213   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?      3           
  Lines             ?    494           
  Branches          ?      0           
=======================================
  Hits              ?    494           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
src/JS.php 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4762aed...ee5b01a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants