Fix '0' being replaces by first string's value

Fixes #99
matthiasmullie · Mar 1, 2016 · 272e461 · 272e461
1 parent 3176239
commit 272e461
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/Minify.php b/src/Minify.php
@@ -318,7 +318,7 @@ protected function extractStrings($chars = '\'"')
         $minifier = $this;
         $callback = function ($match) use ($minifier) {
             // check the second index here, because the first always contains a quote
-            if (!$match[2]) {
+            if ($match[2] === '') {
                 /*
                  * Empty strings need no placeholder; they can't be confused for
                  * anything else anyway.

diff --git a/tests/js/JSTest.php b/tests/js/JSTest.php
@@ -679,6 +679,12 @@ function isJSON(){str.replace(/"[^"\\\n\r]*"|true|false|null|-?\d+(?:\.\d*)?(?:[
             'if(!0){if(!0)console.log("test")}',
         );
 
+        // https://github.com/matthiasmullie/minify/issues/99
+        $tests[] = array(
+            '"object";"object2";"0";"1"',
+            '"object";"object2";"0";"1"',
+        );
+
         //update tests' expected results for cross-system compatibility
         foreach ($tests as &$test) {
             if (!empty($test[1])) {