[MM-974]: Added testcase fore more functions in webhook.go #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raghavaggarwal2308
requested changes
Dec 22, 2024
| for _, tc := range tests { | ||
| t.Run(tc.name, func(t *testing.T) { | ||
| tc.setup() | ||
|
|
There was a problem hiding this comment.
Add mockAPI.ExpectedCalls = nil
| name: "private repo, no permission for author", | ||
| event: GetMockPullRequestReviewEvent(actionSubmitted, "approved", MockRepo, true, "authorUser", "reviewerUser"), | ||
| setup: func() { | ||
| mockKvStore.EXPECT().Get("reviewerUser_githubusername", gomock.Any()).DoAndReturn(func(key string, value interface{}) error { |
There was a problem hiding this comment.
Create util for return value/func
| name: "no subscribed channels for repository", | ||
| event: GetMockStarEvent(MockRepo, MockOrg, false, MockSender), | ||
| setup: func() { | ||
| mockKvStore.EXPECT().Get("subscriptions", gomock.Any()).Return(nil).Times(1) |
There was a problem hiding this comment.
Replace gomock.an() whereever possible
There was a problem hiding this comment.
we can use anythingOfType instead
| setup: func() { | ||
| mockKvStore.EXPECT().Get("subscriptions", gomock.Any()).DoAndReturn(func(key string, value interface{}) error { | ||
| if v, ok := value.(**Subscriptions); ok { | ||
| *v = &Subscriptions{ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added testcase for more functions in webhook.go
Original PR
#855