fix: remove the need for the regex crate's pattern feature
#51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popzxc
approved these changes
Oct 25, 2024
robik75
pushed a commit
that referenced
this pull request
Oct 25, 2024
🤖 I have created a release *beep* *boop* --- ## [0.150.7](v0.150.6...v0.150.7) (2024-10-25) ### Bug Fixes * remove the need for the `regex` crate's `pattern` feature ([#51](#51)) ([042ed7c](042ed7c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
robik75
added a commit
to matter-labs/zksync-crypto-gpu
that referenced
this pull request
Oct 25, 2024
# What ❔ This PR bumps the dependencies from the `zksync-protocol` repo to version `0.150.7` ## Why ❔ `zkevm_test_harness` was updated to fix a problem with the `regex` crate. See matter-labs/zksync-protocol#51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
std::str::pattern::Patterntrait implementation in theregexcrate recently broke compilation with the nightly rust toolchain.The removal of the trait implementation and the corresponding
patternfeature is being planned.This PR removes the reliance on this trait implementation.