-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Pass stipend to the new frame in far call #35
base: main
Are you sure you want to change the base?
Conversation
Did you check that harness doesn't also miss this value during witness generation? |
Yep, I added simple tests with EVM interpreter, everything works after this fix |
|
I'm talking about harness and not non-circuit VM. Harness breaks down our continuous block execution into multiple circuit instances linked together |
Witgen in harness doesn't change anything in callstack entries, they are produced by non-circuit VM. And yes, simple tests in test harness are green, local proving is successful |
Such things zksync-protocol/crates/circuit_definitions/src/aux_definitions/witness_oracle.rs Line 410 in 6e470f4
|
Ran the tests again with 1 cycle per main VM snapshot (per circuit), everything is ok. |
Brings into line with out-of-circuit implementation