Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pass stipend to the new frame in far call #35

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

0xVolosnikov
Copy link
Contributor

Brings into line with out-of-circuit implementation

@shamatar
Copy link
Member

shamatar commented Sep 3, 2024

Did you check that harness doesn't also miss this value during witness generation?

@0xVolosnikov
Copy link
Contributor Author

Did you check

Yep, I added simple tests with EVM interpreter, everything works after this fix

@0xVolosnikov
Copy link
Contributor Author

@shamatar
Copy link
Member

shamatar commented Sep 3, 2024

I'm talking about harness and not non-circuit VM. Harness breaks down our continuous block execution into multiple circuit instances linked together

@0xVolosnikov
Copy link
Contributor Author

Witgen in harness doesn't change anything in callstack entries, they are produced by non-circuit VM. And yes, simple tests in test harness are green, local proving is successful

@shamatar
Copy link
Member

shamatar commented Sep 3, 2024

Such things

and similar one that creates an initial state of the circuit for start. If you did run your tests with circuit chunking being set to 1 cycle then it would be tested, otherwise (if all your test takes 1 circuit chunk to run) - then it may be breaking on transition from one circuit to another

@0xVolosnikov
Copy link
Contributor Author

Ran the tests again with 1 cycle per main VM snapshot (per circuit), everything is ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants