forked from foundry-rs/book
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upstream 58bf161 #48
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update command output Co-authored-by: mattsse <[email protected]>
The guidance provided by the foundry book informs us to setup our tests via ``` contract MyTest is Test { ... } ``` However, given the inheritance and import structures of `forge-std/Test.sol`, the documentation to create a wallet produces the following error: ``` Compiler run failed: Error (7920): Identifier not found or not unique. --> test/MyTest.t.sol:86:5: | 86 | Wallet memory _w = vm.createWallet(100); | ^^^^^^ Error: ``` Instead, in order to store the result returned by `vm.createWallet`, I had to reference the `Wallet` type through the `Vm` interface, like so: ``` Vm.Wallet memory _w = vm.createWallet(100); ```
* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
* doc: add info for vyper lib configuration * 🥢 Fix typo Co-authored-by: evalir <[email protected]> * 📝 Add uv note --------- Co-authored-by: evalir <[email protected]>
Revert "docs: update default `out` folder (foundry-rs#1337)" This reverts commit 1be562e.
update command output Co-authored-by: mattsse <[email protected]>
closing parenthesis missing in function
* Document vm.mockCalls * Add mockCall and mockCalls with `msg.value` param to cheatcodes readme * Add example in mockCalls for mocking with msg.value
This test will not compile if a user follows the docs as written (Error (7576): Undeclared Identifier) . After adding the stdError import they will be able to run the test successfully.
…ation (foundry-rs#1330) * Scripting with Arguments to tutorial * replace codeblock by inline explanation
* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Karrq
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes on par with: matter-labs/foundry-zksync#713
Conflicting files: