Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upstream 58bf161 #48

Merged
merged 14 commits into from
Nov 11, 2024
Merged

chore: upstream 58bf161 #48

merged 14 commits into from
Nov 11, 2024

Conversation

Jrigada
Copy link
Collaborator

@Jrigada Jrigada commented Nov 7, 2024

changes on par with: matter-labs/foundry-zksync#713

Conflicting files:

   README.md
   src/output/cast/cast-call
   src/output/cheatcodes/forge-test-cheatcodes
   src/output/cheatcodes/forge-test-cheatcodes-expectrevert
   src/output/cheatcodes/forge-test-cheatcodes-tracing
   src/output/cheatcodes/forge-test-simple
   src/output/deps/forge-install
   src/output/foundry-template/forge-build
   src/output/foundry-template/forge-test
   src/output/fuzz_testing/forge-test-fail-fuzz
   src/output/fuzz_testing/forge-test-no-fuzz
   src/output/fuzz_testing/forge-test-success-fuzz
   src/output/hello_foundry/forge-build
   src/output/hello_foundry/forge-init
   src/output/hello_foundry/tree-with-files
   src/output/nft_tutorial/forge-test
   src/output/test_filters/forge-test-match-contract-and-test
   src/output/test_filters/forge-test-match-path
   src/reference/cli/SUMMARY.md
   src/reference/cli/cast.md
   src/reference/cli/cast/4byte-decode.md
   src/reference/cli/cast/abi-decode.md
   src/reference/cli/cast/call.md
   src/reference/cli/cast/calldata-decode.md
   src/reference/cli/cast/create2.md
   src/reference/cli/cast/estimate.md
   src/reference/cli/cast/mktx.md
   src/reference/cli/cast/storage.md
   src/reference/cli/cast/wallet/address.md
   src/reference/cli/cast/wallet/list.md
   src/reference/cli/cast/wallet/private-key.md
   src/reference/cli/cast/wallet/sign.md
   src/reference/cli/forge/bind-json.md
   src/reference/cli/forge/bind.md
   src/reference/cli/forge/clone.md
   src/reference/cli/forge/config.md
   src/reference/cli/forge/debug.md
   src/reference/cli/forge/doc.md
   src/reference/cli/forge/eip712.md
   src/reference/cli/forge/init.md
   src/reference/cli/forge/inspect.md
   src/reference/cli/forge/install.md
   src/reference/cli/forge/selectors/collision.md
   src/reference/cli/forge/soldeer.md
   src/reference/cli/forge/verify-bytecode.md
   src/tutorials/solidity-scripting.md

github-actions bot and others added 14 commits October 20, 2024 02:33
The guidance provided by the foundry book informs us to setup our tests via
```
contract MyTest is Test {
...
}
```

However, given the inheritance and import structures of `forge-std/Test.sol`, the documentation to create a wallet produces the following error:

```
Compiler run failed:
Error (7920): Identifier not found or not unique.
  --> test/MyTest.t.sol:86:5:
   |
86 |     Wallet memory _w = vm.createWallet(100);
   |     ^^^^^^

Error: 
```

Instead, in order to store the result returned by `vm.createWallet`, I had to reference the `Wallet` type through the `Vm` interface, like so:
```
Vm.Wallet memory _w = vm.createWallet(100);
```
* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
* doc: add info for vyper lib configuration

* 🥢 Fix typo

Co-authored-by: evalir <[email protected]>

* 📝 Add uv note

---------

Co-authored-by: evalir <[email protected]>
Revert "docs: update default `out` folder (foundry-rs#1337)"

This reverts commit 1be562e.
closing parenthesis missing in function
* Document vm.mockCalls

* Add mockCall and mockCalls with `msg.value` param to cheatcodes readme

* Add example in mockCalls for mocking with msg.value
This test will not compile if a user follows the docs as written (Error (7576): Undeclared Identifier)  . After adding the stdError import they will be able to run the test successfully.
…ation (foundry-rs#1330)

* Scripting with Arguments to tutorial

* replace codeblock by inline explanation
* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
src/cheatcodes/README.md Show resolved Hide resolved
@Jrigada Jrigada merged commit c9d82a3 into main Nov 11, 2024
3 checks passed
@Jrigada Jrigada deleted the upstream-58bf161 branch November 11, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants